This repository was archived by the owner on Nov 4, 2024. It is now read-only.
Install diener from paritytech repository#416
Closed
joao-paulo-parity wants to merge 1 commit into
Closed
Conversation
Contributor
|
Another option that could benefit other CI scripts would be to propose a PR so diener releases include a deb. |
Contributor
Author
IMO better than a deb would be a statically-linked PIE binary. In fact we already have a project like that https://gitlab.parity.io/parity/opstooling/gitlab-guard/-/blob/957b3fd4a51dbc01daf5830b51d7769f03ceb4d2/build#L6-L9 so I think the build command could simply be copied for starters. |
Member
|
Proper solution is here: paritytech/cumulus#1344 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to https://github.com/paritytech/pipeline-scripts/pull/46/files#diff-df602127cd49392d5fb1da82c27351842395a47e788e0c6a77cf52d690ed1d2aR500 where instead of installing
dienerfor everycheck-dependent-*job, we instead bake the binary into the image. That would be better than having to download and install it for each job.Related to paritytech/diener#15